sunhaibotb commented on a change in pull request #10151: [FLINK-14231] Handle
the pending processing-time timers to make endInput semantics on the operator
chain strict
URL: https://github.com/apache/flink/pull/10151#discussion_r373987871
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorFactory.java
##########
@@ -65,20 +68,11 @@ public StreamOperator createStreamOperator(StreamTask
containingTask, StreamConf
capacity,
outputMode,
mailboxExecutor);
+
asyncWaitOperator.setProcessingTimeService(processingTimeService);
Review comment:
For `AsyncWaitOperatorFactory` and `CodeGenOperatorFactory`, we can move the
`processingTimeService` parameter to the constructors. For
`SimpleOperatorFactory`, it seems that we can't do this, because what is stored
in `SimpleOperatorFactory` is already a serialized operator object, unlike the
operators of `AsyncWaitOperatorFactory` and `CodeGenOperatorFactory`, which are
constructed in runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
