[ 
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029491#comment-17029491
 ] 

Canbin Zheng commented on FLINK-15816:
--------------------------------------

Hi [~fly_in_gis] I think it would be good to prevent the bad thing before it 
happens.

I agree with [~trohrmann] that we throw a meaningful exception message telling 
users that the value of \{{kubernetes.cluster-id}} must be no more than xxx 
characters, and also, we should add limitation doc description for the 
\{{kubernetes.cluster-id}} option.

> Limit the maximum length of the value of kubernetes.cluster-id configuration 
> option
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-15816
>                 URL: https://issues.apache.org/jira/browse/FLINK-15816
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Deployment / Kubernetes
>    Affects Versions: 1.10.0
>            Reporter: Canbin Zheng
>            Assignee: Canbin Zheng
>            Priority: Minor
>             Fix For: 1.11.0, 1.10.1
>
>         Attachments: image-2020-01-31-20-54-33-340.png
>
>
> Two Kubernetes Service will be created when a session cluster is deployed, 
> one is the internal Service and the other is the rest Service, we set the 
> internal Service name to the value of the _kubernetes.cluster-id_ 
> configuration option and then set the rest Service name to  
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the 
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name 
> will be *session-test* and the rest Service name be *session-test-rest;* 
> there is a constraint in Kubernetes that the Service name must be no more 
> than 63 characters, for the current naming convention it leads to that the 
> value of _kubernetes.cluster-id_ should not be more than 58 characters, 
> otherwise there are scenarios that the internal Service is created 
> successfully then comes up with a ClusterDeploymentException when trying to 
> create the rest Service.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to