wuchong commented on issue #11011: [FLINK-15658][table-planner-blink] Fix duplicate field names exception when join on the same key multiple times URL: https://github.com/apache/flink/pull/11011#issuecomment-581771189 > Thanks @wuchong , I've always felt that the methods of the `ProjectionCodeGenerator` is a little redundant. > What about add method to `ProjectionCodeGenerator`: > > ``` > def generateProjection( > name: String, > inputType: RowType, > inputMapping: Array[Int]): GeneratedProjection = { > val ctx = CodeGeneratorContext.apply(new TableConfig) > val outputType = RowType.of(inputMapping.map(inputType.getChildren.get):_ *) > generateProjection(ctx, name, inputType, outputType, inputMapping) > } > ``` However, the outputType is still required to build the key BaseRowTypeInfo, so the new method doesn't help much here.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
