ayushtkn commented on issue #11005: [FLINK-15838] Dangling 
CountDownLatch.await(timeout)
URL: https://github.com/apache/flink/pull/11005#issuecomment-581787826
 
 
   Hi @leventov that completely makes sense. In Apache Hadoop too, if the 
method return value is ignored we get a checkstyle warning in the build report, 
but the checkstyles in hadoop, doesn't fail the build. So, in some cases where 
the response isn't of any use, only the execution of the method is important, 
then in that case the committer has the liberty to ignore the checkstyle 
warning.
   But in Flink the build itself will fail, so cases where the response of the 
method isn't needed just the execution is important it can create problem.
   if you say we can create a follow-up jira for this rule integration and 
discuss..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to