tillrohrmann commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r374556295
##########
File path: pom.xml
##########
@@ -390,19 +390,26 @@ under the License.
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
+ </dependency>
+
+ <!-- https://issues.apache.org/jira/browse/FLINK-15868
-->
+ <dependency>
+
<groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-cbor</artifactId>
+ <version>${jackson.version}</version>
</dependency>
Review comment:
Do we really want to change the `jackson-dataformat-cbor` for all
dependencies which rely on it? It would invalidate the testing for all these
components.
On the other hand I guess that the functionality used by Kinesis should then
also be broken for all the other modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
