wangxlong opened a new pull request #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource URL: https://github.com/apache/flink/pull/11016 ## What is the purpose of the change The default implementation of Tablesource#explainSource uses getTableSchema.getFieldNames which is logical fields. So, this pr replace it with physical fields. ## Brief change log 1. Tablesource#explainSource - If produced DataType is composite type, we extract physical schema from it. - If produced DataType is simple, we use the default field name 'f0'. 2. Delete file TableSourceValidationTest in legacy planer, For - TableSourceValidationTest#testPushProjectTableSourceWithoutExplainSource would throw error when without explainSource, the logcial schema and physical schema is different. - TableSourceValidationTest#testPushFilterableTableSourceWithoutExplainSource would throw error no matter whether with explainSource or not. the logcial schema and physical schema is the same. 3. Fix some test fail ## Verifying this change This change is already covered by existing tests, such as 1. TableSourceTest#testProcTimeTableSourceOverWindow 2. TableSourceITCase#testRowtimeLongTableSource ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
