twalthr commented on a change in pull request #10960: [FLINK-15487][table]
Update code generation for new type inference
URL: https://github.com/apache/flink/pull/10960#discussion_r374717503
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala
##########
@@ -172,11 +184,7 @@ object CodeGenUtils {
* We only use TypeInformation to store external type info.
*/
def boxedTypeTermForExternalType(t: DataType): String = {
- if (t.getConversionClass == null) {
-
ClassLogicalTypeConverter.getDefaultExternalClassForType(t.getLogicalType).getCanonicalName
- } else {
- t.getConversionClass.getCanonicalName
- }
+ t.getConversionClass.getCanonicalName
Review comment:
Seems to be legacy. I removed it entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
