carp84 commented on a change in pull request #11018: [FLINK-15905][runtime] Fix 
race condition between allocation and release of OpaqueMemoryResource
URL: https://github.com/apache/flink/pull/11018#discussion_r375111995
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java
 ##########
 @@ -576,7 +577,9 @@ public void releaseAllMemory(Object owner, MemoryType 
memoryType) {
                // if we need to allocate the resource (no shared resource 
allocated, yet), this would be the size to use
                final long numBytes = 
computeMemorySize(fractionToInitializeWith);
 
-               // the initializer attempt to reserve the memory before actual 
initialization
+               // intitializer and releaser as functions that are pushed into 
the SharedResources,
 
 Review comment:
   Minor: intitializer -> initializer

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to