zhijiangW commented on a change in pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the
case of two inputs
URL: https://github.com/apache/flink/pull/11019#discussion_r375154315
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -90,6 +91,10 @@ public static CheckpointedInputGate
createCheckpointedInputGate(
inputGate1.getNumberOfInputChannels() +
inputGate2.getNumberOfInputChannels(),
taskName,
toNotifyOnCheckpoint);
+
+ TaskIOMetricGroup taskIOMetricGroup =
toNotifyOnCheckpoint.getEnvironment().getMetricGroup().getIOMetricGroup();
+ taskIOMetricGroup.gauge("checkpointAlignmentTime",
barrierHandler::getAlignmentDurationNanos);
Review comment:
>deduplicate this code with OneInputStreamTask
I considered that and actually we can remove the method of
`getAlignmentDurationNanos` from `CheckpointedInputGate` to unify the way all
in the constructor of `CheckpointBarrierHandler`. The current way of touching
minimum change is also for catching up with the release ASAP. I would try that
if not very hurry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
