Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r45634054
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -188,9 +189,12 @@ public WebRuntimeMonitor(
// Cancel a job via GET (for proper integration with
YARN this has to be performed via GET)
.GET("/jobs/:jobid/yarn-cancel", handler(new
JobCancellationHandler()))
- // DELETE is the preferred way of cancelling a job
(Rest-conform)
+ // DELETE is the preferred way of canceling a job
(Rest-conform)
.DELETE("/jobs/:jobid", handler(new
JobCancellationHandler()))
+ // stop a job
+ .DELETE("/jobs/:jobid/stop", handler(new
JobStoppingHandler()))
+
--- End diff --
This is somewhat counter-intuitive. `DELETE` is meant to remove the
resource at the specified URI. Specifying a action as `/stop` is not a good
idea. Perhaps a better idea would be to identify these actions as
`/jobs/:jobid?mode=cancel` and `/jobs/:jobid?mode=stop`. @StephanEwen might
have a better idea about this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
