docete opened a new pull request #11021: [FLINK-15546][table-planner-blink] Fix 
obscure error message from Sca…
URL: https://github.com/apache/flink/pull/11021
 
 
   …larOperatorGens::generateCast
   
   
   ## What is the purpose of the change
   
   ScalarOperatorGens::generateCast would produce obscure error message such as 
`Unsupported cast from 'ROW' to 'ROW'.` if we want cast one RowType to 
another.Users are unlikely to figure out what goes wrong from the above error 
message. Something like `Unsupported cast from 'ROW<DECIMAL(2,1), CHAR(3)>' to 
'ROW<DOUBLE, VARCHAR(10)>' `will be more helpful. This PR would fix this.
   
   ## Brief change log
   
   - 0396817 Use `LogicalType` instead of `LogicalTypeRoot` to produce clear 
error message.
   
   ## Verifying this change
   
   This change added tests to verify
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / 
**JavaDocs** / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to