zehuaiWANG commented on a change in pull request #10980:
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r375637375
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java
##########
@@ -199,7 +199,8 @@ static void testCopyFromLocalRecursive(
remotePaths,
localResources,
localResourceDirectory,
- new StringBuilder());
+ new StringBuilder(),
+ 1);
Review comment:
I don't think that setting it to 1 is a good decision. I agree with
@TisonKun 's point of view, rely on default value will be better, and it can
reduce the risk of disrupting the current user settings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
