hequn8128 commented on a change in pull request #11020: [FLINK-15913][python] Add Python TableFunction Runner and Operator in old planner URL: https://github.com/apache/flink/pull/11020#discussion_r375802345
########## File path: flink-python/src/main/java/org/apache/flink/table/runtime/operators/python/PythonTableFunctionOperator.java ########## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.operators.python; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.python.PythonFunctionRunner; +import org.apache.flink.python.env.PythonEnvironmentManager; +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord; +import org.apache.flink.table.functions.TableFunction; +import org.apache.flink.table.functions.python.PythonFunctionInfo; +import org.apache.flink.table.runtime.runners.python.PythonTableFunctionRunner; +import org.apache.flink.table.runtime.types.CRow; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.types.Row; +import org.apache.flink.util.Collector; + +import org.apache.beam.sdk.fn.data.FnDataReceiver; + +/** + * The Python {@link TableFunction} operator for the legacy planner. + */ +public class PythonTableFunctionOperator extends AbstractPythonTableFunctionOperator<CRow, CRow, Row, Row> { + + private static final long serialVersionUID = 1L; + + /** + * The collector used to collect records. + */ + private transient StreamRecordCRowWrappingCollector cRowWrapper; + + public PythonTableFunctionOperator( + Configuration config, + PythonFunctionInfo tableFunction, + RowType inputType, + RowType outputType, + int[] udtfInputOffsets) { + super(config, tableFunction, inputType, outputType, udtfInputOffsets); + } + + @Override + public void open() throws Exception { + super.open(); + this.cRowWrapper = new StreamRecordCRowWrappingCollector(output); + } + + private boolean isFinishResult(Row result) { + return result.getArity() == 0; + } + + @Override + public void emitResults() { + Row udtfResult; + CRow input = null; + while ((udtfResult = udtfResultQueue.poll()) != null) { + if (input == null) { + input = forwardedInputQueue.poll(); + } + if (isFinishResult(udtfResult)) { + input = forwardedInputQueue.poll(); + } + if (input != null && !isFinishResult(udtfResult)) { + cRowWrapper.setChange(input.change()); + cRowWrapper.collect(Row.join(input.row(), udtfResult)); + } + } + } + + @Override + public void bufferInput(CRow input) { + forwardedInputQueue.add(input); + } + + @Override + public Row getUdtfInput(CRow element) { + return Row.project(element.row(), udtfInputOffsets); + } + + @Override + public PythonFunctionRunner<Row> createPythonFunctionRunner( + FnDataReceiver<Row> resultReceiver, + PythonEnvironmentManager pythonEnvironmentManager) { + return new PythonTableFunctionRunner( + getRuntimeContext().getTaskName(), + resultReceiver, + tableFunction, + pythonEnvironmentManager, + udtfInputType, + udtfOutputType); + } + + /** + * The collector is used to convert a {@link Row} to a {@link CRow}. + */ + private static class StreamRecordCRowWrappingCollector implements Collector<Row> { Review comment: This class is copied from `PythonScalarFunctionOperator`. I think we can do some code reuse. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
