NicoK commented on a change in pull request #9489: [FLINK-13793][docs] build
each language in a separate subprocess
URL: https://github.com/apache/flink/pull/9489#discussion_r376316974
##########
File path: docs/build_docs.sh
##########
@@ -72,8 +74,34 @@ while getopts "piez" opt; do
z)
JEKYLL_CONFIG="--config _config.yml,_config_dev_zh.yml"
;;
+ *) echo "usage: $0 [-e|-z] [-i|-p]" >&2
+ exit 1 ;;
esac
done
# use 'bundle exec' to insert the local Ruby dependencies
-bundle exec jekyll ${JEKYLL_CMD} ${JEKYLL_CONFIG} --source "${DOCS_SRC}"
--destination "${DOCS_DST}"
+
+if [ "${JEKYLL_CMD}" = "build" ] && [ -z "${JEKYLL_CONFIG}" ]; then
+ # run parallel builds for all languages if not serving or creating a single
language only
+
+ # run processes and store pids
+ echo "Spawning parallel builds for ${DOC_LANGUAGES}..."
+ pids=
Review comment:
yes it it ;)
but I can also replace it with `pids=""`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
