[
https://issues.apache.org/jira/browse/FLINK-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032305#comment-17032305
]
Jark Wu commented on FLINK-8921:
--------------------------------
[~twalthr] is right, we only split the input operands code into separate
methods in FLINK-15430. We should future split call expressions in blink
planner.
> Split code generated call expression
> -------------------------------------
>
> Key: FLINK-8921
> URL: https://issues.apache.org/jira/browse/FLINK-8921
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Legacy Planner
> Reporter: Timo Walther
> Assignee: xueyu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In FLINK-8274 we introduced the possibility of splitting the generated code
> into multiple methods in order to exceed the JVMs maximum method size (see
> also https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.9).
> At the moment we only split methods by fields, however, this is not enough in
> all case. We should also split expressions. I suggest to split the operands
> of a {{RexCall}} in
> {{org.apache.flink.table.codegen.CodeGenerator#visitCall}} if we reach a
> certain threshold. However, this should happen as lazily as possible to keep
> the runtime overhead low.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
