pnowojski commented on a change in pull request #10435: [FLINK-13955][runtime]
migrate ContinuousFileReaderOperator to the mailbox execution model
URL: https://github.com/apache/flink/pull/10435#discussion_r377009332
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/ContinuousFileProcessingRescalingTest.java
##########
@@ -67,38 +65,47 @@
*/
@Test
public void testReaderScalingDown() throws Exception {
- HarnessWithFormat[] beforeRescale = buildAndStart(5, 15);
+ HarnessWithFormat[] beforeRescale = {};
Review comment:
As I suggested I think using some generic `Closer` would be better, but
let's not block this PR on this (optional nit). I will merge it as it is, we
can clean up the test later on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services