rkhachatryan commented on a change in pull request #10151: [FLINK-14231] Handle
the pending processing-time timers to make endInput semantics on the operator
chain strict
URL: https://github.com/apache/flink/pull/10151#discussion_r377862742
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
##########
@@ -216,13 +216,13 @@ public void onNoMoreData(ContinuousFileReaderOperator<?>
op) {
}
};
- @VisibleForTesting
- public ContinuousFileReaderOperator(FileInputFormat<OUT> format) {
- this.format = checkNotNull(format);
- }
+ public ContinuousFileReaderOperator(
+ FileInputFormat<OUT> format,
+ ProcessingTimeService processingTimeService,
+ MailboxExecutor mailboxExecutor) {
- public ContinuousFileReaderOperator(FileInputFormat<OUT> format,
MailboxExecutor mailboxExecutor) {
this.format = checkNotNull(format);
+ this.processingTimeService =
checkNotNull(processingTimeService);
Review comment:
This operator doesn't use `processingTimerService`. Why set this field?
The same goes for some other operators and their factories.
And if most operator factories don't use it then
`AbstractStreamOperatorFactory` shouldn't have it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
