libenchao commented on a change in pull request #11063:
[FLINK-15938][table-planner-blink] Enable state cleanup in background…
URL: https://github.com/apache/flink/pull/11063#discussion_r378022373
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/stream/state/JoinRecordStateViews.java
##########
@@ -79,6 +79,7 @@ static StateTtlConfig createTtlConfig(long retentionTime,
boolean stateCleaningE
.newBuilder(Time.milliseconds(retentionTime))
.setUpdateType(StateTtlConfig.UpdateType.OnCreateAndWrite)
.setStateVisibility(StateTtlConfig.StateVisibility.ReturnExpiredIfNotCleanedUp)
+ .cleanupInBackground()
Review comment:
Yes. I've explained this in the pr's description, and +1 to only fix for 1.9
branch.
Do you mean I need to open the pr against 1.9 branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
