Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45724616
--- Diff: docs/apis/storm_compatibility.md ---
@@ -57,20 +57,22 @@ See *WordCount Storm* within
`flink-storm-examples/pom.xml` for an example how t
Flink provides a Storm compatible API (`org.apache.flink.storm.api`) that
offers replacements for the following classes:
-- `TopologyBuilder` replaced by `FlinkTopologyBuilder`
- `StormSubmitter` replaced by `FlinkSubmitter`
- `NimbusClient` and `Client` replaced by `FlinkClient`
- `LocalCluster` replaced by `FlinkLocalCluster`
-In order to submit a Storm topology to Flink, it is sufficient to replace
the used Storm classes with their Flink replacements in the Storm *client code
that assembles* the topology.
-The actual runtime code, ie, Spouts and Bolts, can be uses *unmodified*.
-If a topology is executed in a remote cluster, parameters `nimbus.host`
and `nimbus.thrift.port` are used as `jobmanger.rpc.address` and
`jobmanger.rpc.port`, respectively.
-If a parameter is not specified, the value is taken from `flink-conf.yaml`.
+In order to submit a Storm topology to Flink, it is sufficient to replace
the
+used Storm classes with their Flink replacements in the Storm *client code
that
+assembles* the topology. The actual runtime code, ie, Spouts and Bolts,
can be
+used *unmodified*. If a topology is executed in a remote cluster,
parameters
+`nimbus.host` and `nimbus.thrift.port` are used as `jobmanger.rpc.address`
and
+`jobmanger.rpc.port`, respectively. If a parameter is not specified, the
value
+is taken from `flink-conf.yaml`.
--- End diff --
I like the single-line format because it make reviewing easier. If you have
fixed line length, changing a small thing can lead for reformatting of a whole
paragraph due to new line breaks etc. This make spotting the actual change
quite hard. (I would appreciate it, if we could keep the current formatting --
but if is not "an issue" in the strong sense).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
