[ 
https://issues.apache.org/jira/browse/FLINK-16026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036767#comment-17036767
 ] 

Chesnay Schepler commented on FLINK-16026:
------------------------------------------

{{It may be not a good idea to limit the versions of the transitive 
dependencies to a different version declared by the direct dependency:}}

I disagree.

{{We should trust the direct dependency, e.g. if apache-beam declares that it 
support avro-python3<2, we should trust that it does support all versions of 
avro-python3 which are less than 2.}}

Not a single project can guarantee that it supports any future version of 
another library, as they have no control over it.
For all we now, the next version of avro-python3 breaks the entire API.
This is just a broken concept, and we see the fallout of this repeatedly in 
this project and in the JavaScript ecosystem.

{{We have to upgrade the versions of the transitive dependencies periodically 
if new packages have been released}}

Correct, we have to ensure that when we bump a dependency everything still 
works. I don't consider this a bad thing.

{{For released package of PyFlink, there is no way to upgrade the versions of 
the transitive dependencies any more}}

This is not a problem imo, but a benefit. It means the release is stable and 
will not magically stop working 2 years down the road.

> Travis failed due to python setup
> ---------------------------------
>
>                 Key: FLINK-16026
>                 URL: https://issues.apache.org/jira/browse/FLINK-16026
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Python
>            Reporter: Jingsong Lee
>            Assignee: Huang Xingbo
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.10.1, 1.11.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> [https://api.travis-ci.com/v3/job/286671652/log.txt]
> [https://api.travis-ci.org/v3/job/649754603/log.txt]
> [https://api.travis-ci.com/v3/job/286409130/log.txt]
> Collecting avro-python3<2.0.0,>=1.8.1; python_version >= "3.0" (from 
> apache-beam==2.19.0->apache-flink==1.11.dev0) Using cached 
> https://files.pythonhosted.org/packages/31/21/d98e2515e5ca0337d7e747e8065227ee77faf5c817bbb74391899613178a/avro-python3-1.9.2.tar.gz
>  Complete output from command python setup.py egg_info: Traceback (most 
> recent call last): File "<string>", line 1, in <module> File 
> "/tmp/pip-install-d6uvsl_b/avro-python3/setup.py", line 41, in <module> 
> import pycodestyle ModuleNotFoundError: No module named 'pycodestyle' 
> ---------------------------------------- Command "python setup.py egg_info" 
> failed with error code 1 in /tmp/pip-install-d6uvsl_b/avro-python3/ You are 
> using pip version 10.0.1, however version 20.0.2 is available. You should 
> consider upgrading via the 'pip install --upgrade pip' command.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to