Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1398#discussion_r45731094
  
    --- Diff: 
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FileSpout.java
 ---
    @@ -38,6 +38,8 @@
        protected String path = null;
        protected BufferedReader reader;
     
    +   protected boolean finished;
    +
        public FileSpout() {}
    --- End diff --
    
    Yes. But as the argument from above explains. All spout/bolts should be 
written in a Flink agnostic way. No Storm developer would write it like this, 
because this flag does only make sense if you know about `FinitSpout` interface 
-- but you should not assume to know about it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to