rkhachatryan commented on a change in pull request #11071:
[FLINK-16019][runtime] fix ContinuousFileReaderOperator error handling
URL: https://github.com/apache/flink/pull/11071#discussion_r379437858
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
##########
@@ -449,7 +450,7 @@ private void cleanUp() {
try {
r.run();
} catch (Exception e) {
- firstException =
ExceptionUtils.firstOrSuppressed(firstException, e);
+ firstException =
ExceptionUtils.firstOrSuppressed(e, firstException);
Review comment:
I don't think we can have 100% coverage.
Here the fix is trivial, it's check is trivial, the importance is low, the
test is relatively difficult (operator init with all the `Task` required) and
un-reliable.
(also the edit above IMO shouldn't be covered)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
