Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1395#discussion_r45732488
--- Diff:
flink-streaming-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java
---
@@ -40,6 +40,11 @@ public void testCheckpointing() throws Exception {
runCheckpointingTest();
}
+ @Test(expected = RuntimeException.class)
--- End diff --
You don't check the exception here. This means any `RuntimeException` can
make the test pass. IMO not a good test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
