Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45732952
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -595,7 +593,7 @@ public void testGetBinaryByFieldPojoGetter() throws
Exception {
private <T> StormTuple testGetByField(int arity, int index, T value)
throws Exception {
- assert (index < arity);
+ Assert.assertTrue(index < arity);
--- End diff --
Is it? I am not aware if this. Why? Using `assert` to check internal code
invariants is the best way to go IMHO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
