dianfu commented on a change in pull request #11107: [FLINK-16071][python] 
Optimize the cost of the get item of the Row
URL: https://github.com/apache/flink/pull/11107#discussion_r380041933
 
 

 ##########
 File path: flink-python/pyflink/fn_execution/coders.py
 ##########
 @@ -319,7 +338,7 @@ def to_type_hint(self):
 
 @Coder.register_urn(FLINK_SCHEMA_CODER_URN, flink_fn_execution_pb2.Schema)
 
 Review comment:
   What about moving this method to class FlattenRowCoder? It makes the code 
more readable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to