twalthr commented on a change in pull request #11081: [FLINK-16033][table-api]
Introduced Java Table API Expression DSL
URL: https://github.com/apache/flink/pull/11081#discussion_r380081874
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/resolver/LookupCallResolver.java
##########
@@ -63,6 +64,17 @@ public Expression visit(UnresolvedCallExpression
unresolvedCall) {
.collect(Collectors.toList());
}
+ @Override
+ public Expression visitNonApiExpression(Expression other) {
+ // LookupCallResolver might be called outside of
ExpressionResolver, thus we need to additionally
Review comment:
Can't we merge `LookupCallResolver` and `ExpressionResolver` into one
entity? Just an idea...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
