wuchong commented on a change in pull request #11101: 
[FLINK-16068][table-planner-blink] Fix computed column with escaped k…
URL: https://github.com/apache/flink/pull/11101#discussion_r380103215
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/calcite/SqlExprToRexConverter.java
 ##########
 @@ -27,11 +27,15 @@
 
        /**
         * Converts a SQL expression to a {@link RexNode} expression.
+        *
+        * @param expr It's caller's duty to ensure that the expression has 
been escaped correctly.
 
 Review comment:
   ```
   a SQL expression which must be quoted and expanded, e.g. 
"`my_catalog`.`my_database`.`my_udf`(`f0`) + 1".
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to