dawidwys commented on a change in pull request #11081: [FLINK-16033][table-api]
Introduced Java Table API Expression DSL
URL: https://github.com/apache/flink/pull/11081#discussion_r380205913
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/resolver/LookupCallResolver.java
##########
@@ -63,6 +64,17 @@ public Expression visit(UnresolvedCallExpression
unresolvedCall) {
.collect(Collectors.toList());
}
+ @Override
+ public Expression visitNonApiExpression(Expression other) {
+ // LookupCallResolver might be called outside of
ExpressionResolver, thus we need to additionally
Review comment:
I think it's not that simple. We call the `LookupCallResolver` externally
primarily to separate functions into scalar and aggregating functions so that
we can split expressions into ones that go into groupBy clause and those that
go into select clause. Therefore before that step we might not have an input we
can use to fully resolve expressions using `ExpressionResolver`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
