wangyang0918 commented on a change in pull request #11110: [FLINK-16111][k8s]
Fix Kubernetes deployment not respecting 'taskmanager.cpu.cores'.
URL: https://github.com/apache/flink/pull/11110#discussion_r380440613
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
##########
@@ -338,6 +339,7 @@ protected FlinkKubeClient createFlinkKubeClient() {
@Override
protected double getCpuCores(Configuration configuration) {
- return
flinkConfig.getDouble(KubernetesConfigOptions.TASK_MANAGER_CPU,
numSlotsPerTaskManager);
+ double fallback =
configuration.getDouble(KubernetesConfigOptions.TASK_MANAGER_CPU);
+ return
TaskExecutorProcessUtils.getCpuCoresWithFallback(configuration,
fallback).getValue().doubleValue();
Review comment:
Since K8s/Yarn/Mesos share the same logics to get cpu cores, maybe we could
provide a unified method. Then we will not need to test for each implementation.
```
public static <T> CPUResource getCpuCoresWithFallback(final Configuration
config, ConfigOption<T> fallback)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
