wuchong commented on a change in pull request #11047: [FLINK-15912][table] Add
Context to TableSourceFactory and TableSinkFactory
URL: https://github.com/apache/flink/pull/11047#discussion_r380447021
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/factories/StreamTableSourceFactory.java
##########
@@ -39,7 +39,20 @@
* @param properties normalized properties describing a stream table
source.
* @return the configured stream table source.
*/
- StreamTableSource<T> createStreamTableSource(Map<String, String>
properties);
+ default StreamTableSource<T> createStreamTableSource(Map<String,
String> properties) {
+ return null;
+ }
+
+ /**
+ * Creates and configures a {@link StreamTableSource} based on the given
+ {@link Context}.
+ *
+ * @param context context of this table source.
+ * @return the configured table source.
+ */
+ default StreamTableSource<T> createStreamTableSource(Context context) {
Review comment:
But he can still use the `TableSource<T> createTableSource(context)`
interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
