rkhachatryan commented on a change in pull request #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests URL: https://github.com/apache/flink/pull/11096#discussion_r380534049
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java ########## @@ -70,7 +70,6 @@ import org.apache.flink.streaming.api.datastream.DataStreamSource; import org.apache.flink.streaming.api.datastream.SingleOutputStreamOperator; import org.apache.flink.streaming.api.functions.source.ContinuousFileMonitoringFunction; -import org.apache.flink.streaming.api.functions.source.ContinuousFileReaderOperator; Review comment: IMO javadoc of public API shouldn't talk about the implementation classes at all, unless there is a need (here there isn't). And "power users" should be able to go inside the method and see the implementation:) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
