[ 
https://issues.apache.org/jira/browse/FLINK-16147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039099#comment-17039099
 ] 

hailong wang commented on FLINK-16147:
--------------------------------------

Nice, is it ok as follow?
{code:java}
@Override
public String toString() {
   return "WatermarkSpec{rowtime: '" + rowtimeAttribute + '\'' +
      ", watermark: '" + watermarkExpressionString + '\'' +
      ", outputType: '" + watermarkExprOutputType + '\'' +
      "}";
}
{code}
 

> Add watermarkExprOutputType in WatermarkSpec#toString method
> ------------------------------------------------------------
>
>                 Key: FLINK-16147
>                 URL: https://issues.apache.org/jira/browse/FLINK-16147
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Common
>    Affects Versions: 1.10.0
>            Reporter: hailong wang
>            Assignee: hailong wang
>            Priority: Minor
>             Fix For: 1.11.0
>
>
> WatermarkSpec#toString only include rowtimeAttribute and 
> watermarkExpressionString.
> Maybe we should inlcude watermarkExprOutputType too, just like:
> {code:java}
> @Override
> public String toString() {
>    return "rowtime: '" + rowtimeAttribute + '\'' +
>       ", watermark: '" + watermarkExpressionString + '\'' +
>       ", outputType: '" + watermarkExprOutputType + '\'';
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to