azagrebin commented on issue #11109: [FLINK-15758][MemManager] Release segment 
and its unsafe memory in GC Cleaner
URL: https://github.com/apache/flink/pull/11109#issuecomment-587491324
 
 
   > the NIO stack can only access the memory directly if it finds a 
DirectByteBuffer.
   
   Ok then true, that workaround will not work
   
   > Instead, they start with a big DirectByteBuffer (arena or chunk)
   
   Ok, this might work. Just if I understand correctly, this will contribute to 
JVM direct memory limit then. I thought, in general we wanted to keep it only 
for external/user code. Depending on how much memory pre-allocated and then 
(if) (de)allocated more, it will interfere with the user code more or less.
   
   I think `MemorySegments`, allocated with this pooling approach, can still 
benefit from the GC cleaner implemented in this PR, just the GC scheduled 
release operation will be a bit different.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to