rkhachatryan commented on a change in pull request #11098: [FLINK-16060][task]
Implement working StreamMultipleInputProcessor
URL: https://github.com/apache/flink/pull/11098#discussion_r380658811
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
##########
@@ -735,6 +739,56 @@ public StreamGraph generate() {
return Collections.singleton(transform.getId());
}
+ private <OUT> Collection<Integer>
transformMultipleInputTransform(MultipleInputTransformation<OUT> transform) {
+ List<Collection<Integer>> allInputIds = new ArrayList<>();
+
+ for (Transformation<?> input : transform.getInputs()) {
+ allInputIds.add(transform(input));
+ }
+
+ // the recursive call might have already transformed this
+ if (alreadyTransformed.containsKey(transform)) {
+ return alreadyTransformed.get(transform);
+ }
+
Review comment:
Could you please explain:
1. why do we need this check here? there is already one in `transform()`?
2. why the check doesn't precede `transform()` of inputs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
