HuangZhenQiu commented on a change in pull request #10980:
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r381110566
##########
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
##########
@@ -684,12 +710,28 @@ private static void start(YarnConfiguration conf, String
principal, String keyta
}
+ private static void setMiniDFSCluster(String principal, String keytab,
File targetTestClassesFolder) throws Exception {
+ if (miniDFSCluster == null) {
+ Configuration hdfsConfiguration = new Configuration();
+
hdfsConfiguration.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR,
tmpHDFS.getRoot().getAbsolutePath());
+ miniDFSCluster = new MiniDFSCluster
+ .Builder(hdfsConfiguration)
+ .numDataNodes(2)
Review comment:
Bring up more nodes will make test case runs longer and 10 seconds timeout
will be not long enough. File replication number can be multiple on even 1 data
node. It doesn't have to be 1:1 mapping. I put 2 here to make sure the
scenarios of multiple data nodes is covered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
