azagrebin commented on a change in pull request #11073: [FLINK-15672][build]
Migrate to log4j2
URL: https://github.com/apache/flink/pull/11073#discussion_r381220896
##########
File path: tools/log4j-travis.properties
##########
@@ -16,35 +16,52 @@
# limitations under the License.
################################################################################
-log4j.rootLogger=INFO, file
+rootLogger.level = INFO
+rootLogger.appenderRef.out.ref = file
# -----------------------------------------------------------------------------
# Console (use 'console')
# -----------------------------------------------------------------------------
-log4j.appender.console=org.apache.log4j.ConsoleAppender
-log4j.appender.console.layout=org.apache.log4j.PatternLayout
-log4j.appender.console.layout.ConversionPattern=%d{HH:mm:ss,SSS} [%20t] %-5p
%-60c %x - %m%n
+
+appender.console.name = console
+appender.console.type = CONSOLE
+appender.console.layout.type = PatternLayout
+appender.console.layout.pattern = %d{HH:mm:ss,SSS} [%20t] %-5p %-60c %x - %m%n
# -----------------------------------------------------------------------------
# File (use 'file')
# -----------------------------------------------------------------------------
-log4j.appender.file=org.apache.log4j.FileAppender
-log4j.appender.file.file=${log.dir}/mvn-${mvn.forkNumber}.log
-log4j.appender.file.append=true
-log4j.appender.file.layout=org.apache.log4j.PatternLayout
-log4j.appender.file.layout.ConversionPattern=%d{HH:mm:ss,SSS} [%20t] %-5p
%-60c %x - %m%n
+appender.file.name = file
+appender.file.type = FILE
+appender.file.fileName = ${sys:log.dir}/mvn-${sys:mvn.forkNumber}.log
+appender.file.layout.type = PatternLayout
+appender.file.layout.pattern = %d{HH:mm:ss,SSS} [%20t] %-5p %-60c %x - %m%n
# suppress the irrelevant (wrong) warnings from the netty channel handler
-log4j.logger.org.jboss.netty.channel.DefaultChannelPipeline=ERROR
-log4j.logger.org.apache.zookeeper=ERROR
-log4j.logger.org.apache.zookeeper.server.quorum.QuorumCnxManager=OFF
-log4j.logger.org.apache.flink.runtime.leaderelection=DEBUG
-log4j.logger.org.apache.flink.runtime.leaderretrieval=DEBUG
+logger.netty.name = org.jboss.netty.channel.DefaultChannelPipeline
+logger.netty.level = ERROR
+logger.zookeeper.name = org.apache.zookeeper
+logger.zookeeper.level = ERROR
+logger.zkquorum.name = org.apache.zookeeper.server.quorum.QuorumCnxManager
+logger.zkquorum.level = OFF
+logger.leaderretrieval.name = org.apache.flink.runtime.leaderretrieval
+logger.leaderretrieval.level = DEBUG
+logger.leaderelection.name = org.apache.flink.runtime.leaderelection
+logger.leaderelection.level = DEBUG
# Log a bit when running the flink-yarn-tests to avoid running into the 5
minutes timeout for
# the tests
-log4j.logger.org.apache.flink.yarn.YARNSessionFIFOITCase=INFO, console
-log4j.logger.org.apache.flink.yarn.YARNSessionCapacitySchedulerITCase=INFO,
console
-log4j.logger.org.apache.flink.streaming.connectors.kafka=INFO, console
-log4j.logger.org.I0Itec.zkclient=INFO, console
-log4j.logger.org.apache.flink.streaming.connectors.kafka.internals.SimpleConsumerThread=OFF
+logger.yarn1.name = org.apache.flink.yarn.YARNSessionFIFOITCase
Review comment:
maybe also naming convention for logger names containing only some package
suffix (e.g. dash separated if needed) or class name or something like that
I understand names do not matter too much here, just yarn1,2 looks confusing
imo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
