zentol commented on a change in pull request #11073: [FLINK-15672][build]
Migrate to log4j2
URL: https://github.com/apache/flink/pull/11073#discussion_r381329487
##########
File path:
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
##########
@@ -122,7 +129,7 @@ under the License.
<exclude>org.apache.flink:force-shading</exclude>
<exclude>com.google.code.findbugs:jsr305</exclude>
<exclude>org.slf4j:*</exclude>
-
<exclude>log4j:*</exclude>
+
<exclude>org.apache.logging.log4j:*</exclude>
Review comment:
Only `provided` dependencies are excluded by the shade-plugin by default.
I'm not sure why the dependencies are marked as `runtime` and not `provided`,
maybe this makes it more convenient to run in the job in the IDE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
