tzulitai commented on a change in pull request #26: [FLINK-16176] Use
PersistedAppendingBuffer
URL: https://github.com/apache/flink-statefun/pull/26#discussion_r381674686
##########
File path:
statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/httpfn/HttpFunction.java
##########
@@ -112,13 +107,26 @@ private void onAsyncResult(
InvocationResponse invocationResult =
unpackInvocationResultOrThrow(context.self(), asyncResult);
handleInvocationResponse(context, invocationResult);
- InvocationBatchRequest nextBatch = batch.get();
+ InvocationBatchRequest.Builder nextBatch = getNextBatch();
if (nextBatch == null) {
hasInFlightRpc.clear();
return;
}
batch.clear();
- sendToFunction(context, nextBatch.toBuilder());
+ sendToFunction(context, nextBatch);
+ }
+
+ @Nullable
+ private InvocationBatchRequest.Builder getNextBatch() {
+ @Nullable Iterable<Invocation> next = batch.view();
+ if (next == null) {
+ return null;
+ }
+ InvocationBatchRequest.Builder builder =
InvocationBatchRequest.newBuilder();
+ for (Invocation invocation : next) {
Review comment:
I think this can be just `builder.addAllInvocations(nextBatch)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
