wangyang0918 commented on a change in pull request #10980: 
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r381838514
 
 

 ##########
 File path: 
flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java
 ##########
 @@ -261,7 +263,8 @@ private static void testCopySingleFileFromLocal(
                                remotePaths,
                                localResources,
                                localResourceDirectory,
-                               new StringBuilder());
+                               new StringBuilder(),
+                               DFSConfigKeys.DFS_REPLICATION_DEFAULT);
 
 Review comment:
   No, we could not create multiple file replication on single datanode. The 
file will not be accessible until enough datanode has been registered. 
   Since we do not need to access the file here, it makes sense to use 
`DFSConfigKeys.DFS_REPLICATION_DEFAULT`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to