wangyang0918 commented on issue #10980: [FLINK-12343][flink-yarn] add yarn file 
replication configuration
URL: https://github.com/apache/flink/pull/10980#issuecomment-588833119
 
 
   The changes LGTM now.
   @HuangZhenQiu Please make sure you have tested in the following cases in a 
real cluster
   
   * Do not set `yarn.file-replication` in Flink configuration and do not 
update `dfs.replication` in hdfs-site.xml in client, then replication should be 
3
   * Do not set `yarn.file-replication` in Flink configuration and update 
`dfs.replication` to 5 in hdfs-site.xml in client, the replication should be 5
   * Set `yarn.file-replication` to 7 in Flink configuration and update 
`dfs.replication` to 5 in hdfs-site.xml in client, then the replication should 
be 7
   
   @TisonKun Let's wait for @HuangZhenQiu's final verification and merge. 
Thanks a lot. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to