twalthr commented on a change in pull request #11152: [FLINK-16182][table-api]
Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152#discussion_r381889112
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/TypeInferenceUtil.java
##########
@@ -99,6 +99,20 @@ public static AdaptedCallContext adaptArguments(
TypeInference typeInference,
CallContext callContext,
@Nullable DataType outputType) {
+ return adaptArguments(typeInference, callContext, outputType,
true);
+ }
+
+ /**
+ * Adapts the call's argument if necessary.
+ *
+ * <p>This includes casts that need to be inserted, reordering of
arguments (*), or insertion of default
+ * values (*) where (*) is future work.
+ */
+ public static AdaptedCallContext adaptArguments(
+ TypeInference typeInference,
+ CallContext callContext,
+ @Nullable DataType outputType,
+ boolean checkNoUnknownInputTypes) {
Review comment:
nit: `allowUnknownInputTypes` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
