igalshilman commented on a change in pull request #27: [FLINK-16149][core] Set
configurations using StreamExecutionEnvironment#getConfiguration
URL: https://github.com/apache/flink-statefun/pull/27#discussion_r381956919
##########
File path:
statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/functions/FunctionGroupOperator.java
##########
@@ -51,15 +49,19 @@
// -- configuration
private final Map<EgressIdentifier<?>, OutputTag<Object>> sideOutputs;
+ private final StatefulFunctionsConfig configuration;
+
// -- runtime
private transient Reductions reductions;
private transient MailboxExecutor mailboxExecutor;
FunctionGroupOperator(
Map<EgressIdentifier<?>, OutputTag<Object>> sideOutputs,
+ StatefulFunctionsConfig configuration,
MailboxExecutor mailboxExecutor,
ChainingStrategy chainingStrategy) {
this.sideOutputs = Objects.requireNonNull(sideOutputs);
+ this.configuration = configuration;
Review comment:
can you add `Object.requireNonNull`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
