[
https://issues.apache.org/jira/browse/FLINK-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040916#comment-17040916
]
Tristan Tunderman commented on FLINK-16150:
-------------------------------------------
[~aljoscha] Removing the block I've shown in the description indeed solves the
issue.
I would be happy to create a PR for this if there is approval for it. Just to
be sure, the entire block where the block above is part of, is as follows:
{code:java}
<pluginManagement>
<plugins> <!-- This improves the out-of-the-box experience in
Eclipse by resolving some warnings. -->
<plugin>
<groupId>org.eclipse.m2e</groupId>
<artifactId>lifecycle-mapping</artifactId>
<version>1.0.0</version>
<configuration>
<lifecycleMappingMetadata>
<pluginExecutions>
<pluginExecution>
<pluginExecutionFilter>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<versionRange>[3.0.0,)</versionRange>
<goals>
<goal>shade</goal>
</goals>
</pluginExecutionFilter>
<action>
<ignore/>
</action>
</pluginExecution>
<pluginExecution>
<pluginExecutionFilter>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<versionRange>[3.1,)</versionRange>
<goals>
<goal>testCompile</goal>
<goal>compile</goal>
</goals>
</pluginExecutionFilter>
<action>
<ignore/>
</action>
</pluginExecution>
</pluginExecutions>
</lifecycleMappingMetadata>
</configuration>
</plugin>
</plugins>
</pluginManagement>
{code}
Based on your comment of it being old blocks, does the PR need to remove only
the block in the description of the issue, or can the entire block in this
comment be removed?
> Eclipse improvements for archetypes break functionality in vscode-java
> ----------------------------------------------------------------------
>
> Key: FLINK-16150
> URL: https://issues.apache.org/jira/browse/FLINK-16150
> Project: Flink
> Issue Type: Bug
> Components: Quickstarts
> Affects Versions: 1.8.3, 1.10.0
> Reporter: Tristan Tunderman
> Priority: Minor
>
> The Maven archetypes (quickstarts) have some Eclipse oriented improvements in
> `pom.xml`. These are present to improve the "out-of-the-box experience in
> Eclipse by resolving some warnings" (direct citation from the file).
> However, part of these improvements degrade the functionality in vscode in
> combination with the vscode-java extension. This extension provides Java
> language support in vscode (repository can be found here
> [https://github.com/redhat-developer/vscode-java] ).
> The following piece of the XML
> {code:java}
> <pluginExecution>
> <pluginExecutionFilter>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <versionRange>[3.1,)</versionRange>
> <goals>
> <goal>testCompile</goal>
> <goal>compile</goal>
> </goals>
> </pluginExecutionFilter>
> <action>
> <ignore/>
> </action>
> </pluginExecution>
> {code}
> causes all of the autocomplete, code inspections, import fixes etc. provided
> by the vscode-java extension to be supressed.
> I initially created an issue at the vscode-java repo, because I thought the
> issue was in the extension. However, they pointed out that the above piece of
> code causes the supressions (as mentioned here:
> [https://github.com/redhat-developer/vscode-java/issues/1241|https://github.com/redhat-developer/vscode-java/issues/1241)]
> ).
> In the docs the preference for IntelliJ or Eclipse as an IDE is given, but
> only when contributing to the development of Flink itself, not for the
> applications using it. Long story short: is it either possible for the above
> piece of code to be removed (probably not), or can a warning be placed near
> it, or in the docs themselves, to prevent other people from stumbling across
> the same issue when they are using vscode?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
