azagrebin commented on a change in pull request #11073: [FLINK-15672][build] Migrate to log4j2 URL: https://github.com/apache/flink/pull/11073#discussion_r382116466
########## File path: docs/monitoring/logging.md ########## @@ -47,13 +47,15 @@ If you have custom Log4j1 properties files or code that relies on Log4j1, please ## Configuring Log4j1 To use Flink with Log4j1 you must ensure that: -- `org.apache.logging.log4j:log4j-slf4j-impl` and `org.apache.logging.log4j:log4j-1.2-api` are not on the classpath, -- `org.slf4j:slf4j-log4j12`and `log4j:log4j` are on the classpath. +- `org.apache.logging.log4j:log4j-core`, `org.apache.logging.log4j:log4j-slf4j-impl` and `org.apache.logging.log4j:log4j-1.2-api` are not on the classpath, +- `log4j:log4j`, `org.slf4j:slf4j-log4j12`, `org.apache.logging.log4j:log4j-to-slf4j` and `org.apache.logging.log4j:log4j-api` are on the classpath. -In the IDE this means to replacing such dependencies defined in your pom, and possible adding exclusions on dependencies that transitively depend on them. +In the IDE this means you have to replace such dependencies defined in your pom, and possible add exclusions on dependencies that transitively depend on them. Review comment: ```suggestion In the IDE this means you have to replace such dependencies defined in your pom, and possibly add exclusions on dependencies that transitively depend on them. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
