sjwiesman commented on issue #27: [FLINK-16149][core] Set configurations using 
StreamExecutionEnvironment#getConfiguration
URL: https://github.com/apache/flink-statefun/pull/27#issuecomment-589215387
 
 
   @igalshilman and I discussed this offline. 
   
   Instead of discovering the flink-conf via `GlobalConfigurations` we are 
accessing it from `StreamExecutionEnvironment#getConfiguration`. This does 
require reflection as the method is private, but we are guaranteed to 
successfully access the config regardless of deployment method (image, 
standalone, session cluster, etc). Because we only use the config object 
returned in a read-only manner, we deem this safe. 
   
   The call to `StreamExecutionEnvironment#configure` allows us to modify the 
configuration values at runtime. In doing so we can expose all configurations 
to Harness users via `Harness#withConfiguration`. This is the same pattern used 
by the TableConfig in the table api to expose configurations without exposing 
the underlying stream execution environment. Only keys that are set get 
overridden. If a key is not set then its existing values remain. This method is 
public. 
   
   I've updated the PR based on this discussion and the other misc comment on 
this thread. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to