wangyang0918 opened a new pull request #11176: [FLINK-15948][yarn] Enrich the warning log for YARN minimum allocation memory URL: https://github.com/apache/flink/pull/11176 <!-- *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.* ## Contribution Checklist - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component. Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request). - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message (including the JIRA id) - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** --> ## What is the purpose of the change Currently, we just check whether the JobManager/TaskManager is smaller than YARN minimum allocation memory. I think it should be enriched by checking whether it is a multiple of YARN minimum allocation memory. Because YARN will always normalize the resource request by insuring that the requested memory is a multiple of minimum allocation. The minimum allocation could be configured in YARN ResourceManager via 'yarn.scheduler.minimum-allocation-mb'. ## Brief change log * Update the warning log ## Verifying this change * Manually test and logs look like the following ``` 2020-02-21 21:28:40,190 INFO org.apache.flink.yarn.YarnClusterDescriptor - No path for the flink jar passed. Using the location of class org.apache.flink.yarn.YarnClusterDescriptor to locate the jar 2020-02-21 21:28:40,561 WARN org.apache.flink.yarn.YarnClusterDescriptor - The [JobManager memory(1025), TaskManager memory(1568)] is not a multiple of YARN minimum allocation memory(128), so some extra memory will be wasted. Because YARN will always normalize the resource request by insuring that the requested memory is a multiple of minimum allocation. The value of 'yarn.scheduler.minimum-allocation-mb' is '128'. Please increase the specified memory size. 2020-02-21 21:28:40,561 INFO org.apache.flink.yarn.YarnClusterDescriptor - Cluster specification: ClusterSpecification{masterMemoryMB=1025, taskManagerMemoryMB=1568, slotsPerTaskManager=1} 2020-02-21 21:28:40,925 WARN org.apache.hadoop.hdfs.shortcircuit.DomainSocketFactory - The short-circuit local reads feature cannot be used because libhadoop cannot be loaded. 2020-02-21 21:30:26,596 INFO org.apache.flink.yarn.YarnClusterDescriptor - Submitting application master application_1581945672065_0124 2020-02-21 21:30:26,829 INFO org.apache.hadoop.yarn.client.api.impl.YarnClientImpl - Submitted application application_1581945672065_0124 ``` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
