aljoscha commented on a change in pull request #11061: [FLINK-15782] [connectors/jdbc] JDBC sink DataStream API URL: https://github.com/apache/flink/pull/11061#discussion_r382586616
########## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JdbcStatementBuilder.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.java.io.jdbc; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.api.java.io.jdbc.executor.JdbcBatchStatementExecutor; +import org.apache.flink.types.Row; +import org.apache.flink.util.function.BiConsumerWithException; + +import java.io.Serializable; +import java.sql.PreparedStatement; +import java.sql.SQLException; + +import static org.apache.flink.api.java.io.jdbc.JDBCUtils.setRecordToStatement; + +/** + * Sets {@link PreparedStatement} parameters to use in JDBC Sink based on a specific type of StreamRecord. + * @param <T> type of payload in {@link org.apache.flink.streaming.runtime.streamrecord.StreamRecord StreamRecord} + * @see JdbcBatchStatementExecutor + */ +@PublicEvolving +public interface JdbcStatementBuilder<T> extends BiConsumerWithException<PreparedStatement, T, SQLException>, Serializable { + + /** + * Creates a {@link JdbcStatementBuilder} for {@link Row} using the provided SQL types array. + * Uses {@link org.apache.flink.api.java.io.jdbc.JDBCUtils#setRecordToStatement} + */ + static JdbcStatementBuilder<Row> forRow(int[] types) { Review comment: I think in the long run we don't want to have `Row` in non-Table packages. We therefore shouldn't further expose it in our public APIs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
