pnowojski commented on a change in pull request #11098: [FLINK-16060][task]
Implement working StreamMultipleInputProcessor
URL: https://github.com/apache/flink/pull/11098#discussion_r382667265
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/LinkedBufferStorage.java
##########
@@ -56,17 +57,27 @@ public boolean isFull() {
@Override
public void rollOver() {
mainStorage.rollOver();
- linkedStorage.rollOver();
+ for (BufferStorage linked : linkedStorage) {
+ linked.rollOver();
+ }
}
@Override
public long getPendingBytes() {
- return mainStorage.getPendingBytes() +
linkedStorage.getPendingBytes();
+ long pendingBytes = mainStorage.getPendingBytes();
+ for (BufferStorage linked : linkedStorage) {
+ pendingBytes += linked.getPendingBytes();
Review comment:
Usually we treat most of the classes `@NotThreadSafe` by default and
all/almost all of the classes in this package are not thread safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
