[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027098#comment-15027098
]
ASF GitHub Bot commented on FLINK-2837:
---------------------------------------
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890269
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -89,17 +94,16 @@ public BoltWrapper(final IRichBolt bolt) throws
IllegalArgumentException {
* used within a Flink streaming program. The given input schema enable
attribute-by-name access for input types
* {@link Tuple0} to {@link Tuple25}. The output type will be one of
{@link Tuple0} to {@link Tuple25} depending on
* the bolt's declared number of attributes.
- *
- * @param bolt
+ * @param bolt
* The Storm {@link IRichBolt bolt} to be used.
+ * @param inputStreamId
+ * @param inputComponentId
* @param inputSchema
- * The schema (ie, ordered field names) of the input stream.
- * @throws IllegalArgumentException
- * If the number of declared output attributes is not with
range [0;25].
--- End diff --
Why do you delete `@throws` ? More documentation is always better.
> FlinkTopologyBuilder cannot handle multiple input streams
> ---------------------------------------------------------
>
> Key: FLINK-2837
> URL: https://issues.apache.org/jira/browse/FLINK-2837
> Project: Flink
> Issue Type: Bug
> Components: Storm Compatibility
> Reporter: Matthias J. Sax
> Assignee: Maximilian Michels
>
> FlinkTopologyBuilder cannot handle multiple input streams correctly. Instead
> of union the incoming streams, it replicates the consuming bolt and each
> (logical) instance processes one of the input streams.
> For example:
> {noformat}
> final FlinkTopologyBuilder builder = new FlinkTopologyBuilder();
> builder.setSpout(spoutId1, new FiniteRandomSpout(0, 10));
> builder.setSpout(spoutId2, new FiniteRandomSpout(1, 8));
> builder.setSpout(spoutId3, new FiniteRandomSpout(2, 13));
> builder.setBolt(boltId, new MergerBolt())
> .shuffleGrouping(spoutId1)
> .shuffleGrouping(spoutId2)
> .shuffleGrouping(spoutId3);
> builder.setBolt("sink", new BoltPrintSink(new SimpleOutputFormatter()))
> .shuffleGrouping(boltId);
> {noformat}
> will only print the data from a single source instead of all sources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
