hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml]
Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r382961514
##########
File path: flink-ml-parent/flink-ml-lib/pom.xml
##########
@@ -57,4 +57,30 @@ under the License.
<version>1.1.2</version>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <!-- Build flink-ml-lib jar -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <artifactSet>
+ <includes
combine.children="append">
+
<include>com.github.fommil.netlib:core</include>
Review comment:
@walterddr Hi, flink-ml-* are released by jar artifacts and the flink-ml-lib
jar should not contain the license and notice file as it actually does not
bundle the related dependencies. I have fired another
issue([FLINK-16241](https://issues.apache.org/jira/browse/FLINK-16241)) and
will open a corresponding PR to address the problem on release-1.10. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
